Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

george / added tests for OnRampProviderPopup component #4882

Merged
merged 8 commits into from
Feb 23, 2022
Merged

george / added tests for OnRampProviderPopup component #4882

merged 8 commits into from
Feb 23, 2022

Conversation

george-usynin-deriv
Copy link
Contributor

@george-usynin-deriv george-usynin-deriv commented Feb 15, 2022 •
edited
Loading

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Feb 15, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/7aKazfRPK3ukoXBNuJVZRm4eRz9v
✅ Preview: https://deriv-app-git-fork-george-usynin-deriv-53502test-coverag-77259b.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2022 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/4882](https://github.com/binary-com/deriv-app/pull/4882)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-george-usynin-deriv-53502test-coverag-77259b.binary.sx?qa_server=frontend.binaryws.com&app_id=30366
    - **Original**: https://deriv-app-git-fork-george-usynin-deriv-53502test-coverag-77259b.binary.sx
- **App ID**: `30366`

maryia-deriv-archive
maryia-deriv-archive previously approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@maryia-deriv-archive maryia-deriv-archive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

farrah-deriv
farrah-deriv previously approved these changes Feb 15, 2022
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matin-deriv matin-deriv merged commit 6e0dbd4 into binary-com:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhith-deriv likhith-deriv likhith-deriv left review comments

@farrah-deriv farrah-deriv farrah-deriv left review comments

@maryia-deriv-archive maryia-deriv-archive maryia-deriv-archive left review comments

@bahar-sadeghzadeh bahar-sadeghzadeh Awaiting requested review from bahar-sadeghzadeh

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

Assignees
No one assigned
Labels
Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@george-usynin-deriv @farrah-deriv @maryia-deriv-archive @likhith-deriv @matin-deriv